Skip to content

Implement console.time, console.timeEnd, console.timeLog, console.count, and console.countReset#56385

Open
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:feat/console-timing-and-counting-methods
Open

Implement console.time, console.timeEnd, console.timeLog, console.count, and console.countReset#56385
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:feat/console-timing-and-counting-methods

Conversation

@Nedunchezhiyan-M
Copy link
Copy Markdown

@Nedunchezhiyan-M Nedunchezhiyan-M commented Apr 8, 2026

Summary

Implement five console methods that were previously stubbed as no-ops in the React Native console polyfill:

  • console.time(label) - Starts a named timer using high-resolution nativePerformanceNow (with Date.now fallback)
  • console.timeEnd(label) - Logs the elapsed time and removes the timer
  • console.timeLog(label, ...data) - Logs the elapsed time without stopping the timer, with optional extra data
  • console.count(label) - Logs how many times it has been called with the given label
  • console.countReset(label) - Resets the counter for the given label

All five methods follow the WHATWG Console spec:

  • Default label is "default" when none is provided
  • Warnings are logged for duplicate timers, missing timers, and missing counters
  • Labels are coerced to strings

Previously, developers using console.time('myOperation') / console.timeEnd('myOperation') for profiling would silently get no output, making it look like the code was never reached. This was a common source of confusion.

Changelog:

[GENERAL] [ADDED] - Implement console.time, console.timeEnd, console.timeLog, console.count, and console.countReset in the console polyfill

Test Plan

Added consoleTimers-itest.js with tests covering:

  • Basic timer start/end with elapsed time output
  • Default label behavior (uses "default" when omitted)
  • Warning on duplicate timer names
  • Warning on ending/logging nonexistent timers
  • timeLog logging without stopping the timer
  • Multiple concurrent timers
  • Count incrementing and logging
  • Count reset behavior
  • Warning on resetting nonexistent counters
  • Independent tracking of separate labels

…nt, and console.countReset

These methods were previously stubbed as no-ops. Developers using
console.time() for profiling would silently get no output, which
is confusing and makes debugging harder.

The implementation follows the WHATWG Console spec:
- console.time(label) starts a named timer
- console.timeEnd(label) logs elapsed time and removes the timer
- console.timeLog(label, ...data) logs elapsed time without stopping
- console.count(label) logs how many times it has been called
- console.countReset(label) resets a counter

Uses nativePerformanceNow for high-resolution timing when available,
with Date.now as a fallback.
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 8, 2026

Hi @Nedunchezhiyan-M!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Nedunchezhiyan-M Nedunchezhiyan-M force-pushed the feat/console-timing-and-counting-methods branch from a308979 to a7399c2 Compare April 8, 2026 19:58
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 10, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2026
@facebook-github-tools facebook-github-tools bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant